Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NUglify to 1.21.8 (+Test, version upgrade to 5.4 & copyright update to 2024) #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
These are the changes to each version that has been released
on the official Visual Studio extension gallery

## 5.4

- [x] NUglify got updated to 1.21.8

## 5.3

- [x] NUglify got updated to 1.20.3
Expand Down
8 changes: 4 additions & 4 deletions src/BundlerMinifier.Core/BundlerMinifier.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<AssemblyVersion>5.3</AssemblyVersion>
<FileVersion>5.3</FileVersion>
<Version>5.3</Version>
<AssemblyVersion>5.4</AssemblyVersion>
<FileVersion>5.4</FileVersion>
<Version>5.4</Version>
</PropertyGroup>

<ItemGroup>
Expand All @@ -32,7 +32,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NUglify" Version="1.20.3" />
<PackageReference Include="NUglify" Version="1.21.8" />
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Authors>Gérald Barré, Mads Kristensen, RockstarDev, salar2k</Authors>
<Product>Bundler &amp; Minifier TagHelpers</Product>
<PackageLicenseUrl>https://github.com/salarcode/BundlerMinifierPlus/blob/master/LICENSE</PackageLicenseUrl>
<Copyright>Copyright 2022</Copyright>
<Copyright>Copyright 2024</Copyright>
<PackageIconUrl>https://raw.githubusercontent.com/madskristensen/BundlerMinifier/master/src/BundlerMinifierVsix/Resources/icon.png</PackageIconUrl>
<RepositoryUrl>https://github.com/salarcode/BundlerMinifierPlus</RepositoryUrl>
<RepositoryType>git</RepositoryType>
Expand All @@ -16,9 +16,9 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<AssemblyVersion>5.3</AssemblyVersion>
<FileVersion>5.3</FileVersion>
<Version>5.3</Version>
<AssemblyVersion>5.4</AssemblyVersion>
<FileVersion>5.4</FileVersion>
<Version>5.4</Version>
<PackageId>BundlerMinifierPlus.TagHelpers</PackageId>
</PropertyGroup>

Expand Down
10 changes: 5 additions & 5 deletions src/BundlerMinifier/BundlerMinifier.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<Authors>Mads Kristensen, salar2k</Authors>
<Copyright>Copyright 2022</Copyright>
<AssemblyVersion>5.3</AssemblyVersion>
<FileVersion>5.3</FileVersion>
<Version>5.3</Version>
<Copyright>Copyright 2024</Copyright>
<AssemblyVersion>5.4</AssemblyVersion>
<FileVersion>5.4</FileVersion>
<Version>5.4</Version>
</PropertyGroup>

<ItemGroup>
Expand All @@ -35,7 +35,7 @@
<PackageReference Include="Microsoft.Build.Framework" Version="15.9.20" PrivateAssets="All" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.9.20" PrivateAssets="All" />
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" PrivateAssets="All" />
<PackageReference Include="NUglify" Version="1.20.3" PrivateAssets="All" />
<PackageReference Include="NUglify" Version="1.21.8" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
Expand Down
2 changes: 1 addition & 1 deletion src/BundlerMinifierTest/BundlerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public void Process()

// CSS
string cssResult = File.ReadAllText(new FileInfo("../../../artifacts/foo.min.css").FullName);
Assert.AreEqual("body{background:url('/test.png')}body{display:block}:root{--bb-width-test:}body{background:url(test2/image.png?foo=hat)}", cssResult);
Assert.AreEqual("body{background:url('/test.png')}body{display:block}:root{--bb-width-test:}body:nth-child(1 of .test){background-color:#000}body{background:url(test2/image.png?foo=hat)}", cssResult);

// HTML
string htmlResult = File.ReadAllText("../../../artifacts/foo.min.html");
Expand Down
5 changes: 4 additions & 1 deletion src/BundlerMinifierTest/artifacts/file2.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
body {display: block}
:root{
--bb-width-test: ;
}
}
body:nth-child(1 of .test) {
background-color: black;
}