-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset: US_Counties10 #28
Conversation
Signed-off-by: ia <isaac.ardis@gmail.com> add US_Counties10 reference in README Signed-off-by: ia <isaac.ardis@gmail.com> fix misnamed func: s/US_Counties/US_Counties10/g Signed-off-by: ia <isaac.ardis@gmail.com> README.md: add county to location doc Signed-off-by: ia <isaac.ardis@gmail.com>
Reasons you may not want to merge this include that US counties are not exactly well standardized. But, with that said, the feature does in fact add A workaround for this could be to group all the possible subdivision types under an assumed alias of County, potentially yielding more conventionally-expected results.
|
@@ -122,6 +122,7 @@ var testdata = []struct { | |||
SubRegion: "Northern America", | |||
Province: "Alaska", | |||
ProvinceCode: "US-AK", | |||
County: "", // unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28 (comment)
That's why this is empty. Here, TYPE = Municipality|Borough|Census Area
.
Hi, thanks for the PR. I'm not really looking to add more datasets into the lib, but I would be happy to add the counties field to allow you to get that info when using datasets that aren't included. There should probably be a way to get any arbitrary field from the geojson, but I'd be happy to add this for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 98.58% 98.63% +0.04%
==========================================
Files 2 2
Lines 141 146 +5
==========================================
+ Hits 139 144 +5
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Its fine with me either way, I'm happy to use a fork for what I need it for. I think moving toward arbitrary fields from whatever datasets are provided is a very good idea. It would move the library away from being a provider of data structures (which could become a nightmare, and is the real limiter for adding new datasets), and more towards the business of just handling the geometries. |
Thanks for this great lib. I've added
US_Counties10
, and thought I'd PR in case that's something you'd like to have here too.