Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google Analytics and SASS #30

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

PrestonHager
Copy link
Contributor

I added functionality for SASS generation which is pretty standard in Hugo sites. I also fixed issue #27 by adding support for google analytics. The script it uses for Google analytics is the default, but I'm not sure if it's the correct one. There may be a different more generic script we should use for the analytics part.

@dholbach
Copy link
Collaborator

Thanks for the PR! I don't know much about Google Analytics, but would it be possible to use https://gohugo.io/templates/internal/#google-analytics?

@PrestonHager
Copy link
Contributor Author

Looks like a good tool! I went ahead and changed the header.html partial to use the internal Google Analytics that Hugo has.

@dholbach
Copy link
Collaborator

Thanks for the PR @PrestonHager

@dholbach dholbach merged commit 53d5ac7 into sbruder:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants