bz1505037: Add debugging info into passwd-change script #202
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test-openshift] |
hhorak
force-pushed
the
debug-passwd-change
branch
from
e8466f1 to
d4765c3
Compare
|
[test-openshift] |
|
The function |
pkubatrh
reviewed
Jan 19, 2018
| @@ -7,6 +7,14 @@ function log_and_run { | |||
| "$@" | |||
| } | |||
|
|
|||
| function log_debug { | |||
| CONTAINER_DEBUG=${CONTAINER_DEBUG:-} | |||
|
@hhorak ping |
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
|
@hhorak Can you please update this pull request against master and add some documentation? As soon as it is rebased and updated and tests passed we can merge it. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach to fix lack of debugging information in passwd-change script, which was originally reported in https://bugzilla.redhat.com/show_bug.cgi?id=1505037 and #199.