Better typing fix.

scrapy · Oct 13, 2024 · e8c6890 · e8c6890
1 parent 844e37e
commit e8c6890
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/parsel/csstranslator.py b/parsel/csstranslator.py
@@ -80,7 +80,7 @@ class TranslatorMixin:
     """
 
     def xpath_element(self: TranslatorProtocol, selector: Element) -> XPathExpr:
-        # https://github.com/python/mypy/issues/12344
+        # https://github.com/python/mypy/issues/14757
         xpath = super().xpath_element(selector)  # type: ignore[safe-super]
         return XPathExpr.from_xpath(xpath)
 

diff --git a/parsel/selector.py b/parsel/selector.py
@@ -63,7 +63,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
 class CTGroupValue(TypedDict):
     _parser: Union[Type[etree.XMLParser], Type[html.HTMLParser]]
     _csstranslator: Union[GenericTranslator, HTMLTranslator]
-    _tostring_method: str
+    _tostring_method: _TostringMethodType
 
 
 _ctgroup: Dict[str, CTGroupValue] = {
@@ -727,10 +727,7 @@ def get(self) -> Any:
         try:
             return etree.tostring(
                 self.root,
-                method=typing.cast(
-                    "Literal['html', 'text', 'xml']",
-                    _ctgroup[self.type]["_tostring_method"],
-                ),
+                method=_ctgroup[self.type]["_tostring_method"],
                 encoding="unicode",
                 with_tail=False,
             )