Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3082 on branch 1.2.x (ci: Add optional and internet tests) #3084

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #3082: ci: Add optional and internet tests

@lumberbot-app lumberbot-app bot added this to the scvi-tools 1.2 milestone Dec 9, 2024
@lumberbot-app lumberbot-app bot added cuda tests Run test suite on CUDA private tests Run private tests on-merge: backport to 1.2.x on-merge: backport to 1.2.x optional tests Run optional tests internet tests Run internet tests labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (fb54b63) to head (5fd2472).
Report is 1 commits behind head on 1.2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            1.2.x    #3084      +/-   ##
==========================================
+ Coverage   84.39%   89.49%   +5.09%     
==========================================
  Files         173      173              
  Lines       14872    14874       +2     
==========================================
+ Hits        12551    13311     +760     
+ Misses       2321     1563     -758     

see 22 files with indirect coverage changes

@ori-kron-wis
Copy link
Collaborator

private tests are failing (aka hugging face tests) cause only main branch can run them (and it was ok there)

@ori-kron-wis ori-kron-wis self-assigned this Dec 9, 2024
@ori-kron-wis ori-kron-wis merged commit f677929 into scverse:1.2.x Dec 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA internet tests Run internet tests on-merge: backport to 1.2.x on-merge: backport to 1.2.x optional tests Run optional tests private tests Run private tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants