feat: add get_normalized_expression to more models #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpr' into Ori-Additional-Models-Get-Norm-Expr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
- Coverage 89.43% 82.66% -6.78%
==========================================
Files 185 185
Lines 16182 16206 +24
==========================================
- Hits 14473 13397 -1076
- Misses 1709 2809 +1100
|
ori-kron-wis
changed the title
ori-kron-wis
changed the title
canergen
reviewed
Jan 8, 2025
| @@ -33,7 +33,7 @@ | |||
| B = 10 | |||
|
|
|||
|
|
|||
| class CellAssign(UnsupervisedTrainingMixin, BaseModelClass): | |||
| class CellAssign(UnsupervisedTrainingMixin, BaseModelClass, RNASeqMixin, VAEMixin): | |||
There was a problem hiding this comment.
Is CellAssign intended for these functions? I would remove it here.
canergen
reviewed
Jan 8, 2025
src/scvi/module/_mrdeconv.py
Outdated
| z = self.V_encoder(*encoder_input) | ||
| # z = self.gamma_encoder(*encoder_input) | ||
|
|
||
| return { |
There was a problem hiding this comment.
This doesn't really make sense. Please remove VAEmixin from DestVI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add this down stream analysis function to several models which don't have it yet