BUG: fix detection of WAIT_KILLABLE_RECV flag #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel returns EINVAL when this flag is passed to seccomp without the new listener flag so we should pass the along as well. Reference on where the check happens in the kernel: https://github.com/torvalds/linux/blob/aea6bf908d730b01bd264a8821159db9463c111c/kernel/seccomp.c#L1926-L1932 Signed-off-by: Ali Polatel <alip@chesswob.org>
pcmoore
changed the title
pcmoore
reviewed
Nov 30, 2023
pcmoore
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
This looks good to me, what do you think @drakenclimber? A note to whoever ends up merging this, squash the fixup patch into the first patch so there is only one commit in the tree.
Acked-by: Paul Moore <paul@paul-moore.com>
drakenclimber
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel returns EINVAL when this flag is passed to seccomp without the new listener flag so we should pass this flag along as well.
Reference on where the check happens in the kernel:
https://github.com/torvalds/linux/blob/aea6bf908d730b01bd264a8821159db9463c111c/kernel/seccomp.c#L1926-L1932