Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fine grained permission checks #264

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added fine grained permission checks #264

wants to merge 8 commits into from

Conversation

AntonioAngelino
Copy link

I've added the following permission checks to the filebrowser views:

  • can_list_files
  • can_view_files
  • can_add_files
  • can_edit_files
  • can_rename_files
  • can_delete_files
  • can_add_directories

@sehmaschine
Copy link
Owner

Very nice ... we'll consider this with the next major release. I don't think it's a good idea to implement this with a minor version update.

@sehmaschine sehmaschine self-assigned this Jul 22, 2015
@sehmaschine
Copy link
Owner

@AntonioAngelino sorry for the delay, but I have one more question. If we add the permissions, what about existing setups? One needs to assign the permissions to every existing editor, right?

@AntonioAngelino
Copy link
Author

Hi @sehmaschine, yes, you're right.
A migration command may be in charge of creating all required permissions.

@sehmaschine
Copy link
Owner

@AntonioAngelino What about adding a setting like FILEBROWSER_USE_PERMISSIONS which is False by default? This would be backwards compatible. If someone sets it to True, he needs to assign the permissions to editors (which could be documented). Any objections?

@AntonioAngelino
Copy link
Author

Even better and KISS-like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants