Update all non-static Servo preference names to match new names #108
Conversation
|
Yes, I agree. I've tried to keep the changes as small as possible, because the Servo change is unfortunately massive (and this shouldn't land until that is ready). In addition we can probably remove some of these such as the flexbox and transition-behavior preferences. |
| gecko_pref="layout.css.transition-behavior.enabled", | ||
| servo_pref="layout.css.transition-behavior.enabled", | ||
| servo_pref="layout_css_transition_behavior_enabled", |
There was a problem hiding this comment.
I think the inconsistency with gecko prefs looks a bit weird. What's the reasoning for the rename?
There was a problem hiding this comment.
It's unfortunate, but a flat data structure allows setting defaults by using impl Default. For more context see https://servo.zulipchat.com/#narrow/channel/263398-general/topic/Preferences.3A.20defaults.2C.20overrides.2C.20and.20embedders/near/482099593
Unfortunately, Servo is using the output of css-properties.json to generate CSSStyleDeclaration_generated.webidl which needs to properties to match between Stylo and Servo. I'm not sure exactly how to get around this. Maybe some sort of mapping in the Servo code generator?
|
I'm going to go ahead and use mapping in the Servo code generator to accomplish this instead of modifying the Stylo preferences. |
No description provided.