Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix HEVC sample config #229

Merged
merged 1 commit into from
Jan 15, 2025
Merged

docs: Fix HEVC sample config #229

merged 1 commit into from
Jan 15, 2025

Conversation

joeyparrish
Copy link
Member

The key recognized by shaka-streamer is "hevc", not "h265".

@joeyparrish
docs: Fix HEVC sample config
525bc04 
The key recognized by shaka-streamer is "hevc", not "h265".
@joeyparrish joeyparrish requested a review from a team January 15, 2025 18:16
avelad
avelad approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@avelad avelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should add AV1 as well to serve as an example.

@joeyparrish joeyparrish merged commit b22b8c5 into shaka-project:main Jan 15, 2025
16 checks passed
@joeyparrish joeyparrish deleted the fix-sample-config branch January 15, 2025 19:10
@shaka-bot shaka-bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyparrish @avelad