Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of redirect rules to ImportedShlinkUrl model #77

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 20, 2024

Closes #68

Allow importing redirect rules from sources that support it (Shlink for now)

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (80841d2) to head (d533f33).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/Sources/Shlink/ShlinkImporter.php 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #77      +/-   ##
============================================
+ Coverage     95.71%   95.79%   +0.07%     
- Complexity      163      170       +7     
============================================
  Files            38       40       +2     
  Lines           654      689      +35     
============================================
+ Hits            626      660      +34     
- Misses           28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review December 21, 2024 20:10
@acelaya acelaya merged commit 6c305ee into shlinkio:main Dec 21, 2024
8 checks passed
@acelaya acelaya deleted the feature/import-redirect-rules branch December 21, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow importing redirect rules if supported by source
1 participant