7.0.0 #78

gabrielbull · 2017-04-06T13:28:06Z

* Removed $isRobot, setIsRobot(), getIsRobot(), isRobot(), checkBrowserRobot() * Replaced above with detectScriptedAgent() * Added a new ScriptedAgent class with detection for bots, spiders, etc * Added isWebkit(), getIsWebkit(), setIsWebkit() NOTE: TODO: Should add proper browser engine detection (Webkit, Gecko, Trident, etc) * Added $isTwitterWebView, setIsTwitterWebView(), getIsTwitterWebView(), isTwitterWebView(); * Added browser detection for UC Browser * Added browser detection for NSPlayer (Windows Media Player) * Added OS detection for NSPlayer (Windows Media Player) * Added browser detection for Microsoft Office * Added browser detection for the Apple News app * Added browser detection for the Dalvik (Android) OS * Moved wkHTMLtoPDF to scripted agents and removed the test accordingly * Moved GoogleBot to scripted agents * Moved Slurp to scripted agents * Moved W3CValidator to scripted agents * Moved MSNBot to scripted agents * Renamed "Navigator" to "Android Navigator" for clarity * Strip linebreaks in setVersion (fixes a failng test) * Added .idea to the gitignore (I use PHPstorm, don't be a hater) TODO: Tests for new class

Instead of: Match everything except ^ ;\), Match: a-z, A-Z, 0-9, and . only. Remove dirty fudge added to remove the stray \n Now passes tests without said fudge

gabrielbull · 2017-04-06T13:47:21Z

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG

+## 7.0.0 (released 2017-xx-xx)
+
+- ...


Need to add changelog

gabrielbull · 2017-04-06T13:47:55Z

src/Browser.php

@@ -67,12 +64,12 @@ class Browser
    /**
     * @var bool
     */
-    private $isRobot = false;


Need to know if is a scripted agent from here, maybe isScriptedAgent

gabrielbull · 2017-04-06T13:48:21Z

src/Browser.php

-     * @param bool $isRobot
+     * @return ScriptedAgent|bool
+     */
+    public function detectScriptedAgent()


Move this to the ScriptedAgent class like Browser, OS, Device, etc

The reasoning here is that detectScriptedAgent can provide a replacement for $isRobot in this class. This function provides a quick pre-scan to avoid in-depth substring searches in ScriptedAgent if not necessary.

gabrielbull · 2017-04-06T13:49:20Z

tests/BrowserDetector/Tests/ScriptedAgentDetectorTest.php

+{
+    public function testExample()
+    {
+        $this->assertNotFalse(false);


Need to add some tests to assert this is working

gabrielbull · 2017-04-06T13:49:29Z

tests/BrowserDetector/Tests/ScriptedAgentTest.php

+{
+    public function testExample()
+    {
+        $this->assertNotFalse(false);


Need to add some tests to assert this is working

…rsion This adds a lookup table for Edge. This will require some maintenance. If the version cannot be resolved, the browser name "EdgeHTML" is returned rather than "Edge", so that the version number is not misleading. Also fixed regex for edge.

gabrielbull · 2017-04-12T01:59:24Z

src/Browser.php

+            stripos($ua, 'msn') !== false ||
+            stripos($ua, 'Google Web Preview') !== false ||
+            stripos($ua, 'ips-agent') !== false ||
+            (stripos($ua, 'Chrome/51.0.2704.103') !== false && !isset($_SERVER['HTTP_UPGRADE_INSECURE_REQUESTS']) && stristr($_SERVER['HTTP_ACCEPT_LANGUAGE'], "ru-RU") !== false) //ICQ Preview


Shouldn't those checks be done in the ScriptedAgentDetector class?

I anticipated this to be called from $browser in order to be a substitute of $isRobot.

We could still check from the browser class if it is a scripted agent by checking the result of ScriptedAgentDetector. I think it would be cleaner to separate the two and link them with methods instead of having this check in the browser class.

Ok, I'm on board with that.

Cool, do you want to make the change?

…-detector into 7.0.0

gabrielbull · 2017-04-12T13:11:32Z

src/Browser.php

@@ -38,6 +38,7 @@ class Browser
    const GSA = 'Google Search Appliance';
    const YANDEX = 'Yandex';
    const EDGE = 'Edge';
+    const EDGE_HTML = 'EdgeHTML';


This could lead to use error, I'd prefer to still have Edge as the browser and the version be unknown if it is unknown.

Agreed. I am working on engine detection also, so that fits.

gabrielbull · 2017-04-12T13:12:07Z

src/BrowserDetector.php

-            if (isset($version[1])) {
-                self::$browser->setVersion((float)$version[1]);
+            preg_match('/Edge[\\/ \\(]([a-zA-Z\\d\\.]*)/i', self::$userAgentString, $matches);
+            if (sizeof($matches)>1) {


We should check if the version is between the range and provide the closest version if it is.

Example:

"12.10049" => "0.10.10049", "12.10051" => "0.11.10051",

If we detect version 12.10050, we should fallback to the latest available version which would be 0.10.10049. This way, while it may not be 100% accurate, it will provide a fallback to the versions missing in the table.

TomMettam

--

peter279k · 2019-09-03T02:36:02Z

It looks like the StyleCI build is failed.

That is, the coding style check is failed, and I think this should be fixed.

mimmi20 · 2019-09-03T07:51:10Z

src/BrowserDetector.php

+     */
+    public static function checkBrowserUCBrowser()
+    {
+        // Navigator


Do you need this comment in each function?

TomMettam and others added 6 commits March 31, 2017 17:07

Fix typo in README.md

8d6b754

Correct regular expression in Firefox and Seamonkey:

09eba0c

Instead of: Match everything except ^ ;\), Match: a-z, A-Z, 0-9, and . only. Remove dirty fudge added to remove the stray \n Now passes tests without said fudge

Added empty change log for version 7.0.0

b19a930

Added boilerplate tests for srcipted agent

da79d83

Fixed code style

a3874b5

gabrielbull commented Apr 6, 2017

View reviewed changes

gabrielbull added this to the 7.0.0 milestone Apr 6, 2017

gabrielbull added the enhancement label Apr 6, 2017

TomMettam and others added 5 commits April 6, 2017 15:06

Add unit test for EdgeHTML (Un-matched EdgeHTML version string)

0f7bff3

Add tests for the scripted agent detection

a88c162

Fix code style

242c2d7

Few style changes

5568a8a

gabrielbull force-pushed the 7.0.0 branch from 90bbc91 to 5568a8a Compare April 12, 2017 01:56

gabrielbull commented Apr 12, 2017

View reviewed changes

TomMettam and others added 7 commits April 11, 2017 22:16

Add tests for the scripted agent detection

ea8a4c3

Fix code style

301f64c

Few style changes

80b9c26

Added script to fetch latests edge versions from ChangeWindows

910f635

Added wikipedia as edge versions source

d853bbc

Fixed styling

f567a24

Merge branch 'feature/edge-version' of github.com:sinergi/php-browser…

62e8556

…-detector into 7.0.0

gabrielbull commented Apr 12, 2017

View reviewed changes

TomMettam reviewed Apr 20, 2017

View reviewed changes

gabrielbull added 2 commits April 20, 2017 11:26

Removed wikipedia crawling

aa31357

Removed Edge HTML browser

945fa53

mimmi20 reviewed Sep 3, 2019

View reviewed changes

src/BrowserDetector.php

*/

public static function checkBrowserUCBrowser()

{

// Navigator

Copy link

mimmi20 Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this comment in each function?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.0.0 #78

7.0.0 #78

gabrielbull commented Apr 6, 2017 •

edited

Loading

gabrielbull Apr 6, 2017

gabrielbull Apr 6, 2017

gabrielbull Apr 6, 2017

TomMettam Apr 6, 2017

gabrielbull Apr 6, 2017

TomMettam Apr 6, 2017

gabrielbull Apr 6, 2017

TomMettam Apr 6, 2017

gabrielbull Apr 12, 2017

TomMettam Apr 17, 2017

gabrielbull Apr 18, 2017

TomMettam Apr 20, 2017

gabrielbull Apr 20, 2017

gabrielbull Apr 12, 2017

TomMettam Apr 17, 2017

gabrielbull Apr 12, 2017

TomMettam left a comment •

edited

Loading

peter279k commented Sep 3, 2019

mimmi20 Sep 3, 2019

7.0.0 #78

Are you sure you want to change the base?

7.0.0 #78

Conversation

gabrielbull commented Apr 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomMettam left a comment • edited Loading

Choose a reason for hiding this comment

peter279k commented Sep 3, 2019

Choose a reason for hiding this comment

gabrielbull commented Apr 6, 2017 •

edited

Loading

TomMettam left a comment •

edited

Loading