Apply suggestions from code review

Co-authored-by: William Bergamin <william.bergamin.coen@gmail.com>
slackapi · Jan 14, 2025 · 28ee451 · 28ee451
1 parent 980840b
commit 28ee451
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3InstallationService.java
@@ -51,7 +51,7 @@ public AmazonS3InstallationService(
     ) {
         this.bucketName = bucketName;
         this.credentialsProvider = credentialsProvider;
-        this.region = region != null || System.getenv("AWS_REGION") == null ? region : Region.of(System.getenv("AWS_REGION"));
+        this.region = (region != null || System.getenv("AWS_REGION") == null) ? region : Region.of(System.getenv("AWS_REGION"));
         this.endpointOverride = (endpointOverride != null && !endpointOverride.isEmpty()) ? URI.create(endpointOverride) : null;
     }
 

diff --git a/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java b/bolt/src/main/java/com/slack/api/bolt/service/builtin/AmazonS3OAuthStateService.java
@@ -45,7 +45,7 @@ public AmazonS3OAuthStateService(
     ) {
         this.bucketName = bucketName;
         this.credentialsProvider = credentialsProvider;
-        this.region = region != null || System.getenv("AWS_REGION") == null ? region : Region.of(System.getenv("AWS_REGION"));
+        this.region = (region != null || System.getenv("AWS_REGION") == null) ? region : Region.of(System.getenv("AWS_REGION"));
         this.endpointOverride = (endpointOverride != null && !endpointOverride.isEmpty()) ? URI.create(endpointOverride) : null;
     }