Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create undocumented message bot events #1424

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bruceadowns
Copy link

  • create undocumented message bot events
  • message_bot_add
  • message_bot_remove
  • these occur on add/remove of incoming webhook

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

* message_bot_add
* message_bot_remove
* these occur on add/remove of incoming webhook
@bruceadowns bruceadowns marked this pull request as ready for review January 22, 2025 16:55
@bruceadowns
Copy link
Author

@seratch I would like to add these 2 events to my bot, would you pls review. Also, I suspect you may want unit tests, if so pls give me an overview of what tests you’d like to see, and where they go.

@seratch
Copy link
Member

seratch commented Feb 3, 2025

Thanks for taking the time to send this pull request. Let me mention two points:

  • It seems these two subtypes may actually exist but it's not officially listed in the document yet; so at this moment, we're unable to add these changes to SDKs. Our team is communicating with relevant teams on this, so once it's available in the public documents, we can consider adding these classes to this SDK
  • This pull request includes extra changes that are not related to the message event class addition; some of the extra changes seem to be beneficial for this SDK's quality. If you're fine to spend more time, could you revert those changes in this PR and make a different PR for them? We can review it separately

@seratch seratch marked this pull request as draft February 3, 2025 07:35
@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend labels Feb 3, 2025
@seratch seratch added this to the 1.x milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants