CCIP-4948: Adding new test for disable and enable lane #16038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-gopalswami
commented
Jan 22, 2025
| @@ -705,12 +705,10 @@ func UpdateOffRampSourcesChangeset(e deployment.Environment, cfg UpdateOffRampSo | |||
| var args []offramp.OffRampSourceChainConfigArgs | |||
| for source, update := range updates { | |||
| router := common.HexToAddress("0x0") | |||
| if update.IsEnabled { | |||
There was a problem hiding this comment.
router can't be 0x0 address as Offramp expects valid router address ow it will throw ZeroAddressNotAllowed error message.
There was a problem hiding this comment.
If it's not possible to disable a router in offRamp, the parameter IsEnabled should be removed
b-gopalswami
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
makramkd
previously approved these changes
Jan 23, 2025
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
b-gopalswami
force-pushed
the
ccip-4948
branch
from
457f900 to
093222d
Compare
|
AnieeG
requested changes
Jan 24, 2025
| @@ -482,6 +482,45 @@ func AddLane( | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func UpdateLane( | |||
| @@ -705,12 +705,10 @@ func UpdateOffRampSourcesChangeset(e deployment.Environment, cfg UpdateOffRampSo | |||
| var args []offramp.OffRampSourceChainConfigArgs | |||
| for source, update := range updates { | |||
| router := common.HexToAddress("0x0") | |||
| if update.IsEnabled { | |||
There was a problem hiding this comment.
If it's not possible to disable a router in offRamp, the parameter IsEnabled should be removed
| ) { | ||
| var err error | ||
| var apps []commoncs.ChangesetApplication | ||
| apps = append(apps, commoncs.ChangesetApplication{ |
There was a problem hiding this comment.
To disable a lane, I think we need to disable the router to ramp connection, otherwise router will still route the requests to ramps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test to verify the op changeset workflow to disable and re-enable the lane.
Tests it will cover: TC001 & TC002
https://smartcontract-it.atlassian.net/wiki/spaces/QA/pages/1262846210/CCIP+V1.6+Changeset+Test+Plan