solana token pool & on ramp tooling

[tt-cll]

Requires

Supports

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
8 New Major Issues (required ≤ 5)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , GolangCI Lint (deployment) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , lint , SonarQube Scan

1. GolangCI Lint errors: [Golang Lint (deployment)]

Source of Error:

2025-01-24T21:00:06.0427815Z ##[error]deployment/ccip/changeset/testhelpers/test_environment.go:472:15: appendAssign: append result not assigned to the same slice (gocritic)
2025-01-24T21:00:06.0430377Z deployment/solana_chain.go:19: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
2025-01-24T21:00:06.0432384Z deployment/ccip/changeset/cs_add_lane_test.go:8: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
2025-01-24T21:00:06.0435264Z ##[error]deployment/ccip/changeset/testhelpers/test_environment.go:673:18: G115: integer overflow conversion int -> uint8 (gosec)
2025-01-24T21:00:06.0438153Z ##[error]deployment/ccip/changeset/solana/cs_chain_contracts_solana.go:223:5: `TOOD` is a misspelling of `TODO` (misspell)
2025-01-24T21:00:06.0441455Z ##[error]deployment/ccip/changeset/solana/cs_chain_contracts_solana.go:100:6: confusing-naming: Method 'addRemoteChainToSolana' differs only by capitalization to function 'AddRemoteChainToSolana' in the same source file (revive)
2025-01-24T21:00:06.0446113Z ##[error]deployment/ccip/changeset/solana/cs_chain_contracts_solana.go:71:12: fmt.Errorf can be replaced with errors.New (perfsprint)
2025-01-24T21:00:06.0448931Z ##[error]deployment/ccip/changeset/cs_chain_contracts_test.go:153:2: bool-compare: use require.True (testifylint)

Why: The errors are caused by various issues detected by GolangCI Lint, including improper use of append, missing goimports formatting, potential integer overflow, misspellings, confusing naming conventions, and inefficient error handling.

Suggested fix: Address each linting issue by following the recommendations provided by GolangCI Lint. For example, ensure append results are assigned correctly, format files with goimports, handle potential integer overflows, correct misspellings, use clear naming conventions, and replace fmt.Errorf with errors.New where applicable.

2. Test failure due to existing changeset config: [Run tests]

Source of Error:

2025-01-24T21:12:44.8793289Z 	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/cs_deploy_chain_test.go:301
2025-01-24T21:12:44.8793528Z 	Error: 	Received unexpected error:
2025-01-24T21:12:44.8794651Z 	 	failed to apply changeset at index 1: invalid changeset config: don already exists in CR for chain 12463857294658392847, it has id 1

Why: The test failed because the changeset configuration being applied already exists in the Chain Registry (CR) for the specified chain, causing a conflict.

Suggested fix: Modify the test setup to ensure that the changeset being applied does not conflict with existing configurations. This may involve cleaning up the test environment or using unique identifiers for changesets.

3. NodeJS package installation errors: [Setup NodeJS]

Source of Error:

2025-01-24T21:00:16.8117282Z  ERR_PNPM_FETCH_429  GET https://registry.npmjs.org/@nomicfoundation/hardhat-network-helpers/-/hardhat-network-helpers-1.0.12.tgz: Too Many Requests - 429
2025-01-24T21:00:16.8238733Z Progress: resolved 771, reused 354, downloaded 414, added 768
2025-01-24T21:00:16.8610304Z ##[error]Process completed with exit code 1.

Why: The NodeJS package installation failed due to hitting the rate limit on the npm registry, resulting in a "Too Many Requests - 429" error.

Suggested fix: Implement retry logic with exponential backoff for package installations or use a caching mechanism to reduce the number of requests to the npm registry. Additionally, consider using a private npm registry mirror to avoid rate limiting issues.