[DPA-1365]: fix(deployment/mcms): new BuildProposalFromBatch #16221
Conversation
graham-chainlink
requested review from
AnieeG,
kylesmartin and
a team
as code owners
graham-chainlink
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
graham-chainlink
force-pushed
the
ggoh/DPA-1356/BuildProposalFromBatch
branch
from
8099c0d to
853b7b1
Compare
| return nil, fmt.Errorf("missing proposer mcm for chain %d", selector) | ||
| } | ||
| chainID := types.ChainSelector(selector) | ||
| opCount, err := proposerMcms.GetOpCount(nil) |
There was a problem hiding this comment.
I think we can use this https://github.com/smartcontractkit/mcms/blob/d22deb1026094bda5e41126aabd53a0189e96936/sdk/inspector.go#L14 to get the op count. Will also help us by paving a bit the path for when we add support for solana on this one.
There was a problem hiding this comment.
i see, but that would change the api, BuildProposalFromBatchesV2 would have to accept more arguments to build the inspector. Wouldn that make migration harder, i guess we have to do it now or later haha
There was a problem hiding this comment.
alright, i updated the code, didn look too bad, i just needed to accept context and inspector.
There was a problem hiding this comment.
Also i just realized after the update to getOpCount, the BuildProposalFromBatchesV2 also works with solana, so it covers https://smartcontract-it.atlassian.net/browse/DPA-1520 as well @ecPablo
Implement BuildProposalFromBatchV2 which uses the new MCMS library. New changesets can now use this function to build proposals JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1365
graham-chainlink
force-pushed
the
ggoh/DPA-1356/BuildProposalFromBatch
branch
from
853b7b1 to
3087f49
Compare
|
Implement BuildProposalFromBatchV2 which uses the new MCMS library. New changesets can now use this function to build proposals
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1365
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1520