-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source chain specific RMN blessings enable/disable (wip) #16227
base: fix-rmn
Are you sure you want to change the base?
Conversation
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a smoke test that sends a report with unblessed and blessed roots?
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Quality Gate failedFailed conditions |
For initial reviewers:
This PR introduces per-source RMN disabling/enabling.
So far it was globally enabled/disabled.
This required contract changes (check branch diff), affecting offRamp config, commitReport and commitReportAccepted events. The RMN-enabled offRamp config has been moved to per-source and relevant changes were made to the changesets. I'd like a very careful review on this changeset changes to make sure the behavior remains the same on all the envs and tests. Meaning we want to keep the same chains RMN-enabled/disabled as it was before but by using the new config.