Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source chain specific RMN blessings enable/disable (wip) #16227

Draft
wants to merge 14 commits into
base: fix-rmn
Choose a base branch
from

Conversation

dimkouv
Copy link
Contributor

@dimkouv dimkouv commented Feb 5, 2025

For initial reviewers:

This PR introduces per-source RMN disabling/enabling.
So far it was globally enabled/disabled.

This required contract changes (check branch diff), affecting offRamp config, commitReport and commitReportAccepted events. The RMN-enabled offRamp config has been moved to per-source and relevant changes were made to the changesets. I'd like a very careful review on this changeset changes to make sure the behavior remains the same on all the envs and tests. Meaning we want to keep the same chains RMN-enabled/disabled as it was before but by using the new config.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Flakeguard Summary

Ran new or updated tests between fix-rmn and efe73cb (dk/per-src-rmnDisable).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_ActiveCandidate 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 8m56.96s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation
Test_RevokeCandidate 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

@carte7000 carte7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a smoke test that sends a report with unblessed and blessed roots?

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Flakeguard Summary

Ran new or updated tests between fix-rmn and b385278 (dk/per-src-rmnDisable).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployerGroupMCMS 50.00% true true false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 10.14s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
16.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants