Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiet down some logging; stop transmission reaper spam #16239

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Quiet down some logging; stop transmission reaper spam #16239

merged 2 commits into from
Feb 5, 2025

Conversation

samsondav
Copy link
Collaborator

Requires

Supports

@samsondav samsondav requested review from a team as code owners February 5, 2025 17:55
@samsondav samsondav requested a review from chudilka1 February 5, 2025 17:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

jmank88
jmank88 reviewed Feb 5, 2025
View reviewed changes
core/services/chainlink/application.go
@@ -936,7 +937,7 @@ func (app *ChainlinkApplication) stop() (err error) {
err = multierr.Append(err, app.profiler.Stop())
}

app.logger.Info("Exited all services")
app.logger.Debugf("Closed application in %v", time.Since(shutdownStart))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this measuring something different than this line?

chainlink/core/cmd/shell_local.go

Line 345 in 2dadb61

log.Printf("Graceful shutdown time: %s", time.Since(shutdownStartTime))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see that one. Not really, measures something very similar just without the DB close and it will appear in structured logging

msuchacz-cll
msuchacz-cll previously approved these changes Feb 5, 2025
View reviewed changes
@samsondav samsondav force-pushed the quote_server_url_logger_name branch from dd5145b to 2f2c362 Compare February 5, 2025 18:06
@samsondav samsondav force-pushed the quote_server_url_logger_name branch 2 times, most recently from 2d072f3 to be302b9 Compare February 5, 2025 18:10
msuchacz-cll
msuchacz-cll previously approved these changes Feb 5, 2025
View reviewed changes
@samsondav samsondav force-pushed the quote_server_url_logger_name branch 3 times, most recently from a0cce3d to 6e44906 Compare February 5, 2025 18:21
msuchacz-cll
msuchacz-cll previously approved these changes Feb 5, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the quote_server_url_logger_name branch from 6e44906 to 85c9c54 Compare February 5, 2025 19:14
@samsondav samsondav enabled auto-merge February 5, 2025 19:44
jmank88
jmank88 previously approved these changes Feb 5, 2025
View reviewed changes
@samsondav samsondav force-pushed the quote_server_url_logger_name branch from 13654e7 to 562412c Compare February 5, 2025 22:28
@samsondav samsondav requested a review from jmank88 February 5, 2025 22:30
@samsondav samsondav changed the title Quiet down some logging; minor fixes Quiet down some logging; stop transmission reaper spam Feb 5, 2025
bolekk
bolekk approved these changes Feb 5, 2025
View reviewed changes
core/services/llo/cleanup.go
}

t.lggr.Errorw("Failed to reap", "err", err)
select {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just exit to the outer for loop here and follow ticker.C events?

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit a869c7c Feb 5, 2025
182 of 184 checks passed
@samsondav samsondav deleted the quote_server_url_logger_name branch February 5, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@jmank88 jmank88 jmank88 approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

@msuchacz-cll msuchacz-cll Awaiting requested review from msuchacz-cll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsondav @jmank88 @bolekk @msuchacz-cll