Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes decoded err reason in tx #16240

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Feb 5, 2025

  1. The errors were getting returned early without any error reason data for deployer key driven cs executions. It made the decoding problematic with no error reason data. Added a method ConfirmIfNoErrorWithABI which confirms the tx if no error otherwise returns decoded error reason using ABI.
  2. There was a bug in Jobspec CS, it was discarding creation of jobs in case a job was previously proposed irrespective of whether the job is deleted or the proposal is cancelled now. Fixed this by introducing a filter to only discard jobs which are already in proposed, pending, accepted state.
  3. updated code owners for ccip-tooling.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Flakeguard Summary

Ran new or updated tests between develop and 96eb970 (CCIP-5027-revert-reason).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

3 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestEmptyBatch 50.00% true true false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 8.23s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation
TestUpdateNonceManagersCS 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 20.363333333s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation
TestUpdateNonceManagersCS/MCMS_enabled 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 11.146666666s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
14.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@AnieeG AnieeG marked this pull request as ready for review February 6, 2025 00:14
@AnieeG AnieeG requested review from a team and kylesmartin as code owners February 6, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant