Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Workflow Registry Syncer to watch for Unconfirmed transactions #16243

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

justinkaseman
Copy link
Contributor

Description

Speeds up the time it takes for a workflow to land on the nodes by watching for Unconfirmed transactions instead of Finalized.

@justinkaseman justinkaseman requested a review from a team February 5, 2025 19:47
@justinkaseman justinkaseman requested a review from a team as a code owner February 5, 2025 19:47
Copy link
Contributor

github-actions bot commented Feb 5, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@justinkaseman justinkaseman force-pushed the jk/syncer-confidence-level branch from 46f49bc to d401f78 Compare February 5, 2025 19:52
@justinkaseman justinkaseman requested review from cedric-cordenier and a team February 5, 2025 19:52
Copy link
Contributor

github-actions bot commented Feb 5, 2025

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Clean Go Tidy & Generate , Detect Changes , test-scripts , Core Tests (go_core_tests) , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Test failure in syncer package: go_core_tests

Source of Error:
Run tests	2025-02-05T22:41:06.4039964Z FAIL	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer	1200.316s

Why: The test in the syncer package failed, which caused the overall test suite to fail. The specific reason for the failure is not provided in the logs, but it indicates that the test did not complete successfully within the allotted time.

Suggested fix: Investigate the syncer package tests to identify the root cause of the failure. Check for potential issues such as infinite loops, deadlocks, or resource contention that could cause the test to hang or fail. Add more detailed logging to capture the state of the system when the failure occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants