[DPA-1525] solana ccip transfer ownership to timelock #16246
+2,796
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te usage of mcms lib to new version
… mcms deployment. Still pending seed parsing. Also refactored package structure to avoid import cycles.
…wnership # Conflicts: # deployment/ccip/changeset/cs_deploy_chain.go # deployment/ccip/changeset/solana/cs_chain_contracts.go # deployment/ccip/changeset/testhelpers/test_helpers.go # deployment/environment/memory/chain.go # deployment/go.mod # deployment/go.sum
…ana-ccip-transfer-ownership # Conflicts: # deployment/ccip/changeset/solana/cs_chain_contracts.go # deployment/ccip/changeset/solana_state.go # deployment/go.mod # deployment/go.sum
…wnership # Conflicts: # deployment/go.mod # deployment/go.sum
…ana-ccip-transfer-ownership
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan 1. Missing go.sum entry for module:Why: The Go modules required by the project are not listed in the 2. GolangCI Lint errors:Why: The GolangCI Lint tool found various issues in the code, such as unchecked error return values, formatting issues, and potential bugs. |
|
I see you updated files related to
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/DPA-1525
Adds the changeset to transfer ownership of CCIP solana programs. Should be merged after #16159 as FeeQuoter branch was merged here in order to get access to new bindings
TODO:
AI Summary
This pull request includes several changes to the
deployment/ccip/changesetpackage, focusing on improvements and updates to the Solana chain contracts and related tests. The most important changes include updating import statements, modifying function parameters, and adding new functions for initializing and deploying contracts. Additionally, there are updates to the test files to reflect these changes.Changes to Solana Chain Contracts:
Import Statements:
cs_chain_contracts.goandcs_deploy_chain.gofor better organization. [1] [2]Function Modifications:
validateRemoteChainfunction to usechainState.Timelock.ProgramID.String()instead ofchainState.Timelock.DefaultFeeQuoterDestChainConfigfunction to accept an optionaldestChainSelectorparameter and added logic to handle Solana chain selectors. [1] [2]feeQuoterAddressparameter toinitializeRouterfunction and updated its logic accordingly. [1] [2] [3]New Functions:
initializeFeeQuoterfunction to initialize the fee quoter for Solana chains.Changes to Tests:
Import Statements:
cs_chain_contracts_test.goto include new dependencies and remove unused ones.Function Updates:
TestAddRemoteChainandTestAddTokenPoolfunctions to align with the changes in the main codebase, including the use of new structures and configuration parameters. [1] [2] [3] [4]TestAddTokenPoolandTestBillingfunctions. [1] [2]