Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends extra config + chainlink-common bump #16247

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vyzaldysanchez
Copy link
Contributor

Requires

Supports

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

github-actions bot commented Feb 6, 2025

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , GolangCI Lint (core/scripts) , test-scripts , GolangCI Lint (integration-tests/load) , Core Tests (go_core_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_tests_integration) , GolangCI Lint (deployment) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. File is not goimports-ed:

[job id where the error happened]: Golang Lint (deployment)

Source of Error:
Golang Lint (deployment)	2025-02-06T02:27:56.9498606Z deployment/keystone/changeset/internal/ocr3config.go:20: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint (deployment)	2025-02-06T02:27:56.9500000Z 	types2 "github.com/smartcontractkit/chainlink-common/pkg/capabilities/consensus/ocr3/types"

Why: The file ocr3config.go is not formatted according to the goimports tool with the -local flag set to github.com/smartcontractkit/chainlink.

Suggested fix: Run goimports -local github.com/smartcontractkit/chainlink -w deployment/keystone/changeset/internal/ocr3config.go to format the file correctly.

2. TestOCR2TaskJobSpec_String test failure:

[job id where the error happened]: Run tests

Source of Error:
Run tests	2025-02-06T02:43:11.1382180Z --- FAIL: TestOCR2TaskJobSpec_String (0.00s)
Run tests	2025-02-06T02:43:11.1382728Z --- FAIL: TestOCR2TaskJobSpec_String/chain-reader-codec (0.00s)
Run tests	2025-02-06T02:43:11.1386632Z chainlink_models_test.go:132: 
Run tests	2025-02-06T02:43:11.1387731Z 	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/environment/nodeclient/chainlink_models_test.go:132
Run tests	2025-02-06T02:43:11.1388417Z 	Error: 	Not equal: 
Run tests	2025-02-06T02:43:11.1402457Z 	 	expected: "\ntype = \"\"\nname = \"\"\nforwardingAllowed = false\nrelay = \"\"\nschemaVersion = 1\ncontractID = \"\"\n\n[relayConfig]\nchainID = 1337\nfromBlock = 42\n\n[relayConfig.chainReader]\n[relayConfig.chainReader.contracts]\n[relayConfig.chainReader.contracts.median]\ncontractABI = \"[\\n {\\n \\\"anonymous\\\": false,\\n \\\"inputs\\\": [\\n {\\n \\\"indexed\\\": true,\\n \\\"internalType\\\": \\\"address\\\",\\n \\\"name\\\": \\\"requester\\\",\\n \\\"type\\\": \\\"address\\\"\\n }\\n ],\\n \\\"name\\\": \\\"RoundRequested\\\",\\n \\\"type\\\": \\\"event\\\"\\n }\\n]\\n\"\n\n[relayConfig.chainReader.contracts.median.configs]\nLatestRoundRequested = \"{\\n \\\"chainSpecificName\\\": \\\"RoundRequested\\\",\\n \\\"readType\\\": \\\"event\\\"\\n}\\n\"\nLatestTransmissionDetails = \"{\\n \\\"chainSpecificName\\\": \\\"latestTransmissionDetails\\\",\\n \\\"outputModifications\\\": [\\n {\\n \\\"Fields\\\": [\\n \\\"LatestTimestamp_\\\"\\n ],\\n \\\"Type\\\": \\\"epoch to time\\\"\\n },\\n {\\n \\\"Fields\\\": {\\n \\\"LatestAnswer_\\\": \\\"LatestAnswer\\\",\\n \\\"LatestTimestamp_\\\": \\\"LatestTimestamp\\\"\\n },\\n \\\"Type\\\": \\\"rename\\\"\\n }\\n ]\\n}\\n\"\n\n[relayConfig.codec]\n[relayConfig.codec.configs]\n[relayConfig.codec.configs.MedianReport]\ntypeABI = \"[\\n {\\n \\\"Name\\\": \\\"Timestamp\\\",\\n \\\"Type\\\": \\\"uint32\\\"\\n }\\n]\\n\"\n\n"
Run tests	2025-02-06T02:43:11.1421591Z 	 	actual : "\ntype = \"\"\nname = \"\"\nforwardingAllowed = false\nrelay = \"\"\nschemaVersion = 1\ncontractID = \"\"\n\n[relayConfig]\nchainID = 1337\nfromBlock = 42\n\n[relayConfig.chainReader]\n[relayConfig.chainReader.contracts]\n[relayConfig.chainReader.contracts.median]\ncontractABI = \"[\\n {\\n \\\"anonymous\\\": false,\\n \\\"inputs\\\": [\\n {\\n \\\"indexed\\\": true,\\n \\\"internalType\\\": \\\"address\\\",\\n \\\"name\\\": \\\"requester\\\",\\n \\\"type\\\": \\\"address\\\"\\n }\\n ],\\n \\\"name\\\": \\\"RoundRequested\\\",\\n \\\"type\\\": \\\"event\\\"\\n }\\n]\\n\"\n\n[relayConfig.chainReader.contracts.median.configs]\nLatestRoundRequested = \"{\\n \\\"chainSpecificName\\\": \\\"RoundRequested\\\",\\n \\\"readType\\\": \\\"event\\\"\\n}\\n\"\nLatestTransmissionDetails = \"{\\n \\\"chainSpecificName\\\": \\\"latestTransmissionDetails\\\",\\n \\\"outputModifications\\\": [\\n {\\n \\\"EnablePathTraverse\\\": false,\\n \\\"Fields\\\": [\\n \\\"LatestTimestamp_\\\"\\n ],\\n \\\"Type\\\": \\\"epoch to time\\\"\\n },\\n {\\n \\\"EnablePathTraverse\\\": false,\\n \\\"Fields\\\": {\\n \\\"LatestAnswer_\\\": \\\"LatestAnswer\\\",\\n \\\"LatestTimestamp_\\\": \\\"LatestTimestamp\\\"\\n },\\n \\\"Type\\\": \\\"rename\\\"\\n }\\n ]\\n}\\n\"\n\n[relayConfig.codec]\n[relayConfig.codec.configs]\n[relayConfig.codec.configs.MedianReport]\ntypeABI = \"[\\n {\\n \\\"Name\\\": \\\"Timestamp\\\",\\n \\\"Type\\\": \\\"uint32\\\"\\n }\\n]\\n\"\n\n"

Why: The test TestOCR2TaskJobSpec_String failed because the actual output did not match the expected output. The difference is in the LatestTransmissionDetails field where the EnablePathTraverse attribute is missing in the expected output.

Suggested fix: Update the expected output in the test to include the EnablePathTraverse attribute or adjust the code to match the expected output.

3. Test_configureOCR3Request_generateOCR3Config test failure:

[job id where the error happened]: Run tests

Source of Error:
Run tests	2025-02-06T02:43:11.1442923Z --- FAIL: Test_configureOCR3Request_generateOCR3Config (0.00s)
Run tests	2025-02-06T02:43:11.1443333Z ocr3config_test.go:99: 
Run tests	2025-02-06T02:43:11.1444275Z 	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/keystone/changeset/internal/ocr3config_test.go:99
Run tests	2025-02-06T02:43:11.1444902Z 	Error: 	Not equal: 
Run tests	2025-02-06T02:43:11.1480095Z 	 	expected: "{\n \"Signers\": [\n \"011400b35409a8d4f9a18da55c5b2bb08a3f5f68d44442052000b8834eaa062f0df4ccfe7832253920071ec14dc4f78b13ecdda10b824e2dd3b6\",\n \"0114008258f4c4761cc445333017608044a204fd0c006a052000247d0189f65f58be83a4e7d87ff338aaf8956e9acb9fcc783f34f9edc29d1b40\",\n \"011400d4dcc573e9d24a8b27a07bba670ba3a2ab36e5bb052000ba20d3da9b07663f1e8039081a514649fd61a48be2d241bc63537ee47d028fcd\",\n \"0114006607c140e558631407f33bafbabd103863cee876052000046faf34ebfe42510251e6098bc34fa3dd5f2de38ac07e47f2d1b34ac770639f\",\n \"011400a6f35436cb7bffd615cc47a0a04aa0a78696a1440520001221e131ef21014a6a99ed22376eb869746a3b5e30fd202cf79e44efaeb8c5c2\",\n \"011400657587eb55cecd6f90b97297b611c3024e488cc0052000425d1354a7b8180252a221040c718cac0ba0251c7efe31a2acefbba578dc2153\",\n \"0114004885973b2fcf061d5cdfb8f74c5139bd3056e9da0520004a94c75cb9fe8b1fba86fd4b71ad130943281fdefad10216c46eb2285d60950f\",\n \"011400213803bb9f9715379aaf11aadb0212369701dc0a05200096dc85670c49caa986de4ad288e680e9afb0f5491160dcbb4868ca718e194fc8\",\n \"0114008c2aa1e6fad88a6006dfb116eb866cbad2910314052000bddafb20cc50d89e0ae2f244908c27b1d639615d8186b28c357669de3359f208\",\n \"011400679296b7c1eb4948efcc87efc550940a182e610c0520004fa557850e4d5c21b3963c97414c1f37792700c4d3b8abdb904b765fd47e39bf\"\n ],\n \"Transmitters\": [\n \"0x2877F08d9c5Cc9F401F730Fa418fAE563A9a2FF3\",\n \"0x415aa1E9a1bcB3929ed92bFa1F9735Dc0D45AD31\",\n \"0xCea84bC1881F3cE14BA13Dc3a00DC1Ff3D553fF0\",\n \"0xA9eFB53c513E413762b2Be5299D161d8E6e7278e\",\n \"0x6F5cAb24Fb7412bB516b3468b9F3a9c471d25fE5\",\n \"0xdAd1F3F8ec690cf335D46c50EdA5547CeF875161\",\n \"0x19e10B063a62B1574AE19020A64fDe6419892dA6\",\n \"0x9ad9f3AD49e5aB0F28bD694d211a90297bD90D7f\",\n \"0x31B179dcF8f9036C30f04bE578793e51bF14A39E\",\n \"0x0b04cE574E80Da73191Ec141c0016a54A6404056\"\n ],\n \"F\": 3,\n \"OnchainConfig\": \"0x\",\n \"OffchainConfigVersion\": 30,\n \"OffchainConfig\": \"0xc80180e497d012d00180e497d012d80180a8d6b907e00180cab5ee01e80180d88ee16ff0010afa01010a82022003dacd15fc96c965c648e3623180de002b71a97cf6eeca9affb91f461dcd6ce1820220255096a3b7ade10e29c648e0b407fc486180464f713446b1da04f013df6179c8820220dba3c61e5f8bec594be481bcaf67ecea0d1c2950edb15b158ce3dbc77877def3820220b4c4993d6c15fee63800db901a8b35fa419057610962caab1c1d7bed557091278202202a4c7dec127fdd8145e48c5edb9467225098bd8c8ad1dade868325b787affbde820220283471ed66d61fbe11f64eff65d738b59a0301c9a4f846280db26c64c9fdd3f8820220aa3419628ea3536783742d17d8adf05681aa6a6bd2b206fbde78c7e5aa38586d82022001496edce35663071d74472e02119432ba059b3904d205e4358014410e4f2be3820220ad08c2a5878cada53521f4e2bb449f191ccca7899246721a0deeea19f7b83f70820220c805572b813a072067eab2087ddbee8aa719090e12890b15c01094f0d3f74a5f8a02008a02008a02008a02008a02008a02008a02008a02008a02008a02008a020098028094ebdc03a0028094ebdc03a8028094ebdc03b0028094ebdc03ba02f8010a20da47a8cc1c10796dd43f98ed113c648625e2e504c16ac5da9c65669e2377241b1220f5beca3bb11406079dc174183105c474c862a73c257ce8b3d9f5ca065e6264691a10805015e4203740495a23e93c1bd06ba81a10ca58ff36ffb0545dc3f800ddd6f8d0481a1076f664639ca8b5209e488895faa5460f1a104a1e89a7f2d8c89158f18856bf289c2a1a10c2f4330787831f419713ad4990e347d31a10fd403ec0797c001a2794b51d6178916d1a10e14fff88fdd3d1554ed861104ddc56a81a10b0284b9817fec2c3066c6f2651d17fc41a10b090233a67d502f78191c9e19a2a032b1a10e483414860bb612af50ee15ce8cd8ef5c00280e497d012c8028094ebdc03\"\n}"
Run tests	2025-02-06T02:43:11.1532913Z 	 	actual : "{\n \"Signers\": [\n \"011400b35409a8d4f9a18da55c5b2bb08a3f5f68d44442052000b8834eaa062f0df4ccfe7832253920071ec14dc4f78b13ecdda10b824e2dd3b6\",\n \"0114008258f4c4761cc445333017608044a204fd0c006a052000247d0189f65f58be83a4e7d87ff338aaf8956e9acb9fcc783f34f9edc29d1b40\",\n \"011400d4dcc573e9d24a8b27a07bba670ba3a2ab36e5bb052000ba20d3da9b07663f1e8039081a514649fd61a48be2d241bc63537ee47d028fcd\",\n \"0114006607c140e558631407f33bafbabd103863cee876052000046faf34ebfe42510251e6098bc34fa3dd5f2de38ac07e47f2d1b34ac770639f\",\n \"011400a6f35436cb7bffd615cc47a0a04aa0a78696a1440520001221e131ef21014a6a99ed22376eb869746a3b5e30fd202cf79e44efaeb8c5c2\",\n \"011400657587eb55cecd6f90b97297b611c3024e488cc0052000425d1354a7b8180252a221040c718cac0ba0251c7efe31a2acefbba578dc2153\",\n \"0114004885973b2fcf061d5cdfb8f74c5139bd3056e9da0520004a94c75cb9fe8b1fba86fd4b71ad130943281fdefad10216c46eb2285d60950f\",\n \"011400213803bb9f9715379aaf11aadb0212369701dc0a05200096dc85670c49
</cicore>
  
    
<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/13172800136) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/13172817019/job/36766088004) , [commit](https://github.com/smartcontractkit/chainlink/commit/8b26176c89092a2968ccc14dd572669ae795c91a)

</operatoruici>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant