Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding separated test for rules and validator #1 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joseluistorres
Copy link

@solojavier please provide feedback

@@ -13,7 +13,15 @@
@valuator.add_rule instructor_followed_rule
end

it "testing first rule" do
it "testing first rule example" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to: "returns a LikeRule instance"

@joseluistorres
Copy link
Author

@solojavier take a look and let me know.
Not sure what you mean with this

Create rule mocks and stub apply method
Validate that rank returns the sum of applying rules...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants