Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ $ cd shiplift
1. open an issue describing the feature/bug you wish to contribute first to start a discussion, explain why, what and how
2. use rustfmt, see below how to configure
3. try to write tests covering code you produce as much as possible, especially critical code branches
4. add notes/hightlights for the changelog in the pull request description
4. add notes/highlights for the changelog in the pull request description


### Configuring rustfmt
Expand Down
4 changes: 2 additions & 2 deletions src/container.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1306,8 +1306,8 @@ pub struct HostConfig {
pub cpu_percent: i64,
#[serde(rename = "IOMaximumIOps")]
pub io_maximum_iops: u64,
#[serde(rename = "IOMaximumBandwith")]
pub io_maximum_bandwith: Option<u64>,
#[serde(rename = "IOMaximumBandwidth")]
pub io_maximum_bandwidth: Option<u64>,
pub binds: Option<Vec<String>>,
#[serde(rename = "ContainerIDFile")]
pub container_id_file: String,
Expand Down
6 changes: 3 additions & 3 deletions src/exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl<'docker> Exec<'docker> {
}

// To not tie the lifetime of `opts` to the stream, we do the serializing work outside of
// the stream. But for backwards compatability, we have to return the error inside of the
// the stream. But for backwards compatibility, we have to return the error inside of the
// stream.
let body_result = opts.serialize();

Expand All @@ -100,7 +100,7 @@ impl<'docker> Exec<'docker> {

Box::pin(
async move {
// Bubble up the error inside the stream for backwards compatability
// Bubble up the error inside the stream for backwards compatibility
let body: Body = body_result?.into();

let exec_id = docker
Expand Down Expand Up @@ -159,7 +159,7 @@ impl<'docker> Exec<'docker> {
)
}

/// Inspect this exec instance to aquire detailed information
/// Inspect this exec instance to acquire detailed information
///
/// [Api Reference](https://docs.docker.com/engine/api/v1.41/#operation/ExecInpsect)
pub async fn inspect(&self) -> Result<ExecDetails> {
Expand Down
4 changes: 2 additions & 2 deletions src/image.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl<'docker> Images<'docker> {
}

// To not tie the lifetime of `opts` to the 'stream, we do the tarring work outside of the
// stream. But for backwards compatability, we have to return the error inside of the
// stream. But for backwards compatibility, we have to return the error inside of the
// stream.
let mut bytes = Vec::default();
let tar_result = tarball::dir(&mut bytes, opts.path.as_str());
Expand All @@ -127,7 +127,7 @@ impl<'docker> Images<'docker> {
let docker = self.docker;
Box::pin(
async move {
// Bubble up error inside the stream for backwards compatability
// Bubble up error inside the stream for backwards compatibility
tar_result?;

let value_stream = docker.stream_post_into(
Expand Down