Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: ResolutionCtx refactor #323

Merged
merged 4 commits into from
Sep 16, 2024
Merged

impr: ResolutionCtx refactor #323

merged 4 commits into from
Sep 16, 2024

Conversation

iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Sep 13, 2024

This implementation should hopefully be more performant, and prepares for the existence of new layers (function ctx layers for TGSL, etc.)

@iwoplaza iwoplaza self-assigned this Sep 13, 2024
@@ -4,7 +4,6 @@
"version": "0.0.1",
"scripts": {
"dev:watch": "astro dev",
"dev:build": "astro build",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to prebuild the website before watching, is nothing depends on the website.

@iwoplaza iwoplaza marked this pull request as ready for review September 13, 2024 11:41
Copy link
Collaborator

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

packages/typegpu/src/resolutionCtx.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🛠️💜

@iwoplaza iwoplaza merged commit 8e341d3 into main Sep 16, 2024
4 checks passed
@iwoplaza iwoplaza deleted the impr/resolution-ctx-refactor branch September 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants