Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluid with atomics example #671

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

reczkok
Copy link
Collaborator

@reczkok reczkok commented Dec 18, 2024

closes #657

Copy link

codesandbox-ci bot commented Dec 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@reczkok reczkok marked this pull request as ready for review January 7, 2025 12:17
@reczkok reczkok requested review from iwoplaza and mhawryluk and removed request for iwoplaza January 8, 2025 10:54
@mhawryluk
Copy link
Collaborator

packages/typegpu dev:watch: Export "AnyWgslData" of module "src/data/wgslTypes.ts" was reexported through module "src/data/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
packages/typegpu dev:watch: Either change the import in "src/core/slot/accessor.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.
packages/typegpu dev:watch: Export "AnyWgslData" of module "src/data/wgslTypes.ts" was reexported through module "src/data/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
packages/typegpu dev:watch: Either change the import in "src/core/slot/slotTypes.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.
packages/typegpu dev:watch: Export "AnyData" of module "src/data/dataTypes.ts" was reexported through module "src/data/index.ts" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
packages/typegpu dev:watch: Either change the import in "src/tgpuBindGroupLayout.ts" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.

⚠️

Copy link
Collaborator

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remember to merge the main branch, because experimental is no more
  • brush size value is effectively shifted by 1 (setting 0 draws 1 square)
  • it is very difficult to draw anything with timestep set to low values and size to high (high performance demand) (don't know if we can do anything about this, maybe rearranging the order of operations could help somehow?)

@reczkok reczkok requested a review from mhawryluk January 20, 2025 09:03
Copy link
Collaborator

@mhawryluk mhawryluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🌊

@reczkok reczkok requested a review from iwoplaza January 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fluid with atomics example
3 participants