Create typegpu babel plugin #804
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
packages/plugin/package.json
Outdated
There was a problem hiding this comment.
Since we're planning to rewrite the plugin in unplugin (at least the parts that will run on rollup and rollup-adjacent bundlers), we should IMO go with the name unplugin-typegpu.
https://github.com/unplugin/unplugin-starter/tree/main
It will be less ambiguous what the plugin is for, and will be easier to find 🙌
There was a problem hiding this comment.
Also, could we call the directory unplugin-typegpu instead of matching the current convention and calling it unplugin? I feel like for packages living under the @typegpu namespace it would be fine, but this will make it more clear which package it represents.
| @@ -14,6 +15,8 @@ type Context = { | |||
| stack: Scope[]; | |||
| }; | |||
|
|
|||
| type JsNode = babel.Node | acorn.AnyNode; | |||
There was a problem hiding this comment.
I'm wondering if it wouldn't be easier to switch to @types/estree and use the babel plugin to convert the AST? What do you think?
There was a problem hiding this comment.
Maybe then we could have a parser agnostic implementation
There was a problem hiding this comment.
sure, I can try and see how viable this is
Co-authored-by: Iwo Plaza <iwoplaza@gmail.com>
closes #796