Implement more performant partial IO #808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
reczkok
commented
Jan 29, 2025
Comment on lines
+47
to
+49
| const sortedProps = Object.entries(propOffsets).sort( | ||
| (a, b) => a[1].offset - b[1].offset, // Sort by offset | ||
| ); |
There was a problem hiding this comment.
The propOffsets should always be in the correct order already. But I don't think it's guaranteed. It doesn't cost much to sort it here.
| throw new Error('Partial value for array must be an array'); | ||
| } | ||
|
|
||
| partialValue.sort((a, b) => a.idx - b.idx); |
There was a problem hiding this comment.
This is necessary since we don't want to sort all the write instructions later. If we don't sort here the instructions will still be valid but will not get properly merged. Sorting here is way less of an overhead than sorting all the instructions.
reczkok
requested review from
iwoplaza and
mhawryluk
and removed request for
iwoplaza
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance vs #803: