feat: duplicate worklets code the smart way #6827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/worklets/restructure-worklets-source-sets
branch
from
b30c495 to
2634199
Compare
tjzel
force-pushed
the
@tjzel/worklets/duplicate-reanimated-code
branch
from
d723ecc to
62c9488
Compare
…lets-source-sets' into @tjzel/worklets/duplicate-reanimated-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the transitional period of
react-native-workletscoming as a separate package, Reanimated should work with or withoutreact-native-workletsinstalled. This requires the code of Worklets to be present both inreact-native-reanimatedandreact-native-worklets.This PR duplicated that code using hard links, so nothing is effectively duplicated. Worklet files remain committed in
react-native-reanimatedfor the time being and they are hard linked when executingyarn buildinreact-native-workletsworkspace.I moved
ReanimatedVersion.cpp/hfiles back to Reanimated. We'll implement version checking for Worklets when we actually need it.Test plan
Run an Example with these changes.
Then do
yarn add react-native-worklets(it will use workspace version by default) in the example directory and run it again.