Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest - script #8

Merged
merged 25 commits into from
Jan 10, 2024
Merged

Install latest - script #8

merged 25 commits into from
Jan 10, 2024

Conversation

war-in
Copy link
Contributor

@war-in war-in commented Jan 5, 2024

No description provided.

@war-in war-in requested review from THenry14 and Arcticae January 5, 2024 10:24
@war-in war-in self-assigned this Jan 5, 2024
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
@war-in war-in requested a review from THenry14 January 5, 2024 11:48
@war-in
Copy link
Contributor Author

war-in commented Jan 5, 2024

It would be nice if someone could verify if the script works correctly in his environment 🙏

@THenry14
Copy link
Member

THenry14 commented Jan 5, 2024

It would be nice if someone could verify if the script works correctly in his environment 🙏

Tested on ubuntu x86/arm64 + mac m1, everything works 👍
I think there will be a problem with windows (added comment), but sadly I do not have any windows pc to test this out (maybe a good idea would be to use windows on some test gh action to verify?)

scripts/install.sh Outdated Show resolved Hide resolved
@war-in war-in requested a review from THenry14 January 5, 2024 14:37
scripts/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this script work with asdf installations? How would one upgrade when using foundry from asdf? I think this functionality should be added here (variable location of the binary)

.github/workflows/ci.yml Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
@war-in war-in mentioned this pull request Jan 8, 2024
@war-in
Copy link
Contributor Author

war-in commented Jan 8, 2024

Does this script work with asdf installations? How would one upgrade when using foundry from asdf? I think this functionality should be added here (variable location of the binary)

My idea was to install this binary and add it to the path so snfoundry asdf could just run this script and have it installed.
If someone would like to upgrade the binary he would have to run the script by himself. The same way he does it when installing snfoundryup
https://foundry-rs.github.io/starknet-foundry/getting-started/installation.html#install-via-snfoundryup

@war-in war-in requested review from THenry14 and Arcticae January 8, 2024 07:34
scripts/install.sh Outdated Show resolved Hide resolved
@war-in
Copy link
Contributor Author

war-in commented Jan 8, 2024

I've created an issue to improve the installation script #10

scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
@war-in war-in requested a review from THenry14 January 10, 2024 12:34
scripts/install.sh Show resolved Hide resolved
@war-in war-in merged commit 75ef6be into master Jan 10, 2024
10 checks passed
@war-in war-in deleted the war-in/installation-script branch January 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants