Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diamond Helper Functions #158
base: master
Are you sure you want to change the base?
Diamond Helper Functions #158
Changes from 1 commit
a7edda4
420964c
047964e
9d3a62d
9d3b060
20bf78e
b2eda57
398ff37
f9a6c2c
45b2dc4
3d9d456
e702c36
5f34d05
1aa7db8
f00863e
c8195bc
f43c14a
c93c0a5
e5d19a2
dfac641
669a620
cef5a3f
ce286c6
a2a3c19
c7df310
7d6598e
9d92ea0
a9b12a5
f4c211b
dbf11d5
871f868
54da442
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The add/replace/remove function names imply that a transaction is sent, but really they just generate the
FacetCut
formatting. Should change the name to something likegenerateFacetCutsForAdd
. Can you think of something better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions are rather specific, so I think they should throw errors if certain passed data can't be added/removed/replaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like a function that takes a list of selectors and targets, and calculates the
FacetCut
diff needed to migrate an existing diamond to the given schema.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked ChatGPT for help here, how about
addUnregisteredSelectorsToFacetCut
? Likewise, the other functions could be renamedreplaceRegisteredSelectorsInFacetCut
andremoveRegisteredSelectorsFromFacetCut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e702c36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
45b2dc4