1.31: test/transforms: add failing test for overwritting extraction source #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes issues with string_view per cpp guides
|
Issues linked to changelog: |
EItanya
reviewed
Jan 13, 2025
test/extensions/filters/http/transformation/transformation_filter_test.cc
Outdated
Show resolved
Hide resolved
…ter_test.cc Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will forward port after
Change extraction and their storage mechanism (extractions) to use std::string rather than absl::string_view.
This lets us avoid the bad usage of string_views per https://abseil.io/docs/cpp/guides/strings.
Previously this would ONLY affect configuration where a header was both extracted from and set in the same resolution.
See the breaking test #395
https://storage.googleapis.com/solo-public-build-logs/logs.html?buildid=d0c7341e-a39c-4c18-9823-535dd36333d7