support data source in transform #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfuden
reviewed
Jan 31, 2025
source/extensions/filters/http/transformation/inja_transformer.cc
Outdated
Show resolved
Hide resolved
nfuden
approved these changes
Feb 2, 2025
… the actual pr description for a better real desc
EItanya
reviewed
Feb 3, 2025
api/envoy/config/filter/http/transformation/v2/transformation_filter.proto
Outdated
Show resolved
Hide resolved
EItanya
reviewed
Feb 3, 2025
|
|
||
| const auto &data_sources = transformation.data_sources(); | ||
| for (auto it = data_sources.begin(); it != data_sources.end(); it++) { | ||
| auto provider_or_error = Envoy::Config::DataSource::DataSourceProvider::create( |
There was a problem hiding this comment.
I'm not super familiar with the Envoy::Config::DataSource::DataSourceProvider::create. Does this load the data on the data path or pre-load? Doing the former seems potentially expensive.
There was a problem hiding this comment.
There was a problem hiding this comment.
So this is using it like how the router filter is using it.
There was a problem hiding this comment.
yes, it watches for file updates
EItanya
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new features for transformation.
First is the trim option which will trim ascii whitespace from both the start and end of the value provided.
This can be used like so: {{ trim(my_super_cool_value) }}
Second is the datasource option. This pulls from a mounted datasource to provide data or an empty string.
This can be used like so {{ data_source("my_cool_mounted_file") }}
One may often want to use the trim functionality in combination with this new feature.