Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: ensure ScrollDown button only takes it's width #6143

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ichim-david
Copy link
Collaborator

Fixes #6133

This pull request allow interaction with interactive elements if we can see them.
Previously the button parent took full width making it impossible to interact with the other elements unless scrolling.

Test plan

Scroll until you see the Scroll to End button.
Check that you can interact with the buttons such as Copy or Execute.

Here are some screenshots with Cody within VSCode and with the storybook for ScrollDown
storybook-text-select-not-possible
storybook-text-select
cody-scroll-to-end-broken
cody-scroll-to-end-fixed

Changelog

Chat: ensure ScrollDown button only takes it's width allowing the interaction with other elements

@ichim-david
Copy link
Collaborator Author

@vovakulikov I noticed you worked with ScrollDown component in #5386.
Would love to get a review from you or maybe you can CC someone else if that person is better suited to review this work.
CC @jdorfman and thank you guys in advance.

@vovakulikov
Copy link
Contributor

@ichim-david sure, styles changes over scroll down button look fine, this PR has some other unrelated as I see changes, let me know when it's ready for official review.

- This way we allow interaction with interactive elements if we
  can see them. Previously the button parent took full width making
  it impossible to interact with the other elements unless scrolling
@ichim-david ichim-david reopened this Nov 18, 2024
@ichim-david
Copy link
Collaborator Author

ichim-david commented Nov 18, 2024

@ichim-david sure, styles changes over scroll down button look fine, this PR has some other unrelated as I see changes, let me know when it's ready for official review.

@vovakulikov sorry about that, git commit -a added more that I wanted in this pull request. I've forced pushed the change that was needed for this fix.
It's ready for review now, thank you.

@ichim-david
Copy link
Collaborator Author

@beyang what's the review and merging workflow for community contributions like this one?

I got approval from @vovakulikov but it's not clear to me who does the merging, if someone from
a release team needs to think about when it should be merged, if for such a simple fix all of the tests
needs to run and if so tests should be allowed to run for Contributor roles.

TLDR I want to follow the right process as long as I know what this process is like :)

@beyang
Copy link
Member

beyang commented Nov 19, 2024

@ichim-david we're currently in the midst of revamping how we review community contributions. For now, ping @jdorfman and he'll surface them me or the appropriate dev. This obviously doesn't scale, but it's a stopgap while we pin down a process that works with our internal eng cadence. Apologies for the delays on reviews—thank you so much for these contributions and for bearing with us on the current process pain points 🙏

@beyang beyang enabled auto-merge (squash) November 19, 2024 19:02
@beyang beyang merged commit 53592fb into sourcegraph:main Nov 19, 2024
32 of 37 checks passed
@ichim-david ichim-david deleted the 6133_skip_to_end branch November 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Skip to end" button occupies excessive space — prevents text selection in adjacent areas
3 participants