-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: ensure ScrollDown button only takes it's width #6143
Conversation
@vovakulikov I noticed you worked with ScrollDown component in #5386. |
@ichim-david sure, styles changes over scroll down button look fine, this PR has some other unrelated as I see changes, let me know when it's ready for official review. |
be19fe0
to
0070f3c
Compare
- This way we allow interaction with interactive elements if we can see them. Previously the button parent took full width making it impossible to interact with the other elements unless scrolling
@vovakulikov sorry about that, git commit -a added more that I wanted in this pull request. I've forced pushed the change that was needed for this fix. |
@beyang what's the review and merging workflow for community contributions like this one? I got approval from @vovakulikov but it's not clear to me who does the merging, if someone from TLDR I want to follow the right process as long as I know what this process is like :) |
@ichim-david we're currently in the midst of revamping how we review community contributions. For now, ping @jdorfman and he'll surface them me or the appropriate dev. This obviously doesn't scale, but it's a stopgap while we pin down a process that works with our internal eng cadence. Apologies for the delays on reviews—thank you so much for these contributions and for bearing with us on the current process pain points 🙏 |
Fixes #6133
This pull request allow interaction with interactive elements if we can see them.
Previously the button parent took full width making it impossible to interact with the other elements unless scrolling.
Test plan
Scroll until you see the Scroll to End button.
Check that you can interact with the buttons such as Copy or Execute.
Here are some screenshots with Cody within VSCode and with the storybook for ScrollDown
Changelog
Chat: ensure ScrollDown button only takes it's width allowing the interaction with other elements