[Backport vscode-v1.64.x] Release Omnibox: remove feature flag #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: https://linear.app/sourcegraph/issue/PROD-425/implement-version-compatibility Remove OneBox featureflag usage and enable the features based on SG site version > 6.0. ## Test plan - Make sure all omnibox features are working with s2 but not with demo.sourcegraph.com (cherry picked from commit 99faa39)
thenamankumar
requested changes
Jan 22, 2025
disable omnibox on dotcom ## Test plan - connect to s2 and omnibox should work as intended. - connect to dotcom all the omnibox features should be hidden. (cherry picked from commit 99faa39) <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> Co-authored-by: Naman Kumar <naman@outlook.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/sourcegraph/issue/PROD-425/implement-version-compatibility
Remove OneBox featureflag usage and enable the features based on SG site version > 6.0.
Test plan
Backport 99faa39 from Release Omnibox: remove feature flag #6710