Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport vscode-v1.64.x] chore(ES): update CTAs and eligibility logic #6825

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sourcegraph-release-bot
Copy link
Collaborator

Updated CTA links and eligibility logic, see Loom and CODY-4659 for full details

https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480

Closes https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links.

Test plan

  1. Tested CTA eligibility on dotcom, and enterprise instances
  2. Checked dismiss notifications did not break webview
  3. Checked links and confirmed that they matched with designs
  4. Switched across multiple accounts and everything still worked


Backport 7da7444 from #6803

Updated CTA links and eligibility logic, see Loom and
[CODY-4659](https://linear.app/sourcegraph/issue/CODY-4659/profile-menu-ctas)
for full details

https://www.loom.com/share/2222084d04a14e1ba080b06c92207a19?sid=67bc08e2-e284-4616-92e4-1f087145a480

Closes
https://linear.app/sourcegraph/issue/CORE-535/cody-clients-migrate-ctas-to-live-links.

## Test plan
1. Tested CTA eligibility on dotcom, and enterprise instances
2. Checked dismiss notifications did not break webview
3. Checked links and confirmed that they matched with designs
4. Switched across multiple accounts and everything still worked
<!-- Required. See
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->

(cherry picked from commit 7da7444)
@sourcegraph-release-bot sourcegraph-release-bot requested review from kalanchan and a team January 27, 2025 22:20
@thenamankumar thenamankumar merged commit 8ddd2e8 into vscode-v1.64.x Jan 28, 2025
21 of 23 checks passed
@thenamankumar thenamankumar deleted the backport-6803-to-vscode-v1.64.x branch January 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants