Backport 6833 to jb v7.12.x #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: - Removes the intent toggle feature completely. - Changes the intent dropdown behavior to only select the intent and not execute it automatically. - Enables the submit button even when the chat is empty. - the intent options in the dropdown only selects the intent mode and doesn't execute it. - after selecting the intent, changing the input, doesn't reset the intent. - on submit the selected intent is used and the intent selection message is displayed accordingly. - loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected. - selecting a prompt correctly executes it in chat & edit modes. - make sure the submit button isn't disabled when the input is empty.
thenamankumar
force-pushed
the
backport-6833-to-jb-v7.12.x
branch
from
ab8549f to
7f0e531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: #6833
This PR:
Removes the intent toggle feature completely.
Changes the intent dropdown behavior to only select the intent and not execute it automatically.
Enables the submit button even when the chat is empty.
Test plan
the intent options in the dropdown only selects the intent mode and doesn't execute it.
after selecting the intent, changing the input, doesn't reset the intent.
on submit the selected intent is used and the intent selection message is displayed accordingly.
loading a chat from history and editing the message, doesn't persist the intent mode previously manually selected.
selecting a prompt correctly executes it in chat & edit modes.
make sure the submit button isn't disabled when the input is empty.