[Backport jb-v7.12.x] fix: define all base64 characters #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered a bug related to serialization of @ mention prompts. With
this PR I explicitly list all base64 characters, and properly handle the
trailing equal signs.
Essentially we extend the regex `[a-zA-Z0-9]+` to `[A-Za-z0-9+/]+={0,2}`
following https://datatracker.ietf.org/doc/html/rfc4648#section-4.
## Test plan
More unit tests
(cherry picked from commit deb3fa2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug related to serialization of @ mention prompts. With this PR I explicitly list all base64 characters, and properly handle the trailing equal signs.
Essentially we extend the regex
[a-zA-Z0-9]+to[A-Za-z0-9+/]+={0,2}following https://datatracker.ietf.org/doc/html/rfc4648#section-4.Test plan
More unit tests
Backport deb3fa2 from #6837