fix: handle missing spaces around @ mentions in cody chat #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahrmichael
changed the title
thenamankumar
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM. We tested for some edge cases, which got missed in the fix here: #6837
This handles them correctly.
This was referenced Jan 28, 2025
bahrmichael
added a commit
that referenced
this pull request
Jan 28, 2025
… cody chat (#6844) This PR updates cody chat to also use proper regex splitting. Manual verification that it can handle spaces in the chat: <img width="536" alt="Screenshot 2025-01-28 at 15 09 37" src="https://github.com/user-attachments/assets/9bb65e34-533c-41a6-9c5b-f2133f550bc9" /> ## Test plan Unit tests + manual testing <br> Backport 6e8d30d from #6842 Co-authored-by: Michael Bahr <1830132+bahrmichael@users.noreply.github.com>
bahrmichael
added a commit
that referenced
this pull request
Jan 28, 2025
…s in cody chat (#6843) This PR updates cody chat to also use proper regex splitting. Manual verification that it can handle spaces in the chat: <img width="536" alt="Screenshot 2025-01-28 at 15 09 37" src="https://github.com/user-attachments/assets/9bb65e34-533c-41a6-9c5b-f2133f550bc9" /> ## Test plan Unit tests + manual testing <br> Backport 6e8d30d from #6842 Co-authored-by: Michael Bahr <1830132+bahrmichael@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cody chat to also use proper regex splitting.
Manual verification that it can handle spaces in the chat:
Test plan
Unit tests + manual testing