Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JB] Temp add Omnibox FF #6847

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

thenamankumar
Copy link
Member

As per the thread: https://sourcegraph.slack.com/archives/C05AGQYD528/p1738076320715949?thread_ts=1738004127.714799&cid=C05AGQYD528

This PR adds the Omnibox FF back.

THIS MUST BE REVERTED BEFORE THE CODY RELEASE ON 29th.

@umpox

Test plan

  • set overrides for ff cody-experimental-one-box on s2
  • when the ff is on, the omnibox elements, intent dropdown in the submit button, auto intent detection and search results should work
  • when the ff is off, all the omnibox elements should be hidden and auto intent detection also should not work.

Tested manually.

@thenamankumar thenamankumar changed the title Temp add Omnibox FF [JB] Temp add Omnibox FF Jan 28, 2025
@thenamankumar thenamankumar merged commit b595dd0 into jb-v7.12.x Jan 28, 2025
21 of 23 checks passed
@thenamankumar thenamankumar deleted the naman/temp-put-omnibox-ff-jb branch January 28, 2025 15:36
umpox added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants