[Backport jb-v7.12.x] feat(auto-edit): fix the temperature value regression with the auto-edit #6852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit (#6848) ## Context 1. We received multiple reports describing inconsistent model outputs in the "auto-edit" feature. 2. We initially used a temperature value of 0.2. On December 17, we set it to 0 in the [client-side PR](https://github.com/sourcegraph/cody/pull/6363/files)(released December 22 pre-release, December 29 stable) for more consistent generation. 3. The [issue arises in cody-gateway](https://github.com/sourcegraph/sourcegraph/blob/main/cmd/cody-gateway/internal/httpapi/completions/upstream.go#L318), when JSON-marshaling the request, any zero-valued fields (like temperature=0) get dropped before being sent to Fireworks. 4. Because no temperature is passed, [Fireworks defaults to a temperature of 1](https://docs.fireworks.ai/api-reference/post-completions#body-temperature), which is significantly higher than intended and leads to inconsistent outputs. 5. This PR changes the value from 0 to 0.1. To decide the value, we did an offline evaluation on couple of prompts on over ~100 requests and got consistent output for the requests. ## Test plan 1. Fixed the test cases and CI 2. Local testing on the prompt to ensure the output is consistent. --------- Co-authored-by: Tom Ross <tom@umpox.com> (cherry picked from commit b585001)
umpox
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
We can consider this approved for backport via this message from @beyang: https://sourcegraph.slack.com/archives/C089TSH61KR/p1738017476230839?thread_ts=1738014461.934859&cid=C089TSH61KR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Test plan
Backport b585001 from feat(auto-edit): fix the temperature value regression with the auto-edit #6848