Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(marketing): update listing description #6862

Merged
merged 3 commits into from
Jan 29, 2025
Merged

chore(marketing): update listing description #6862

merged 3 commits into from
Jan 29, 2025

Conversation

kalanchan
Copy link
Contributor

@kalanchan kalanchan commented Jan 29, 2025 •
edited
Loading

Updating plugin description as requested by Marketing (thread)

Copy from Notion

Test plan

N/A - text change but we should test whether this uploads successfully in the marketplace

@kalanchan kalanchan requested review from a team and umpox January 29, 2025 07:16
@kalanchan kalanchan enabled auto-merge (squash) January 29, 2025 07:16
@kalanchan
Copy link
Contributor Author

@umpox I also touched some of the JetBrains gradle properties, I think they should be okay? if the build breaks tomorrow we can revert that portion, VS Code can be updated first

umpox
umpox reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left some comments, I think @beyang should take a look too

jetbrains/gradle.properties Outdated
@@ -1,7 +1,7 @@
# IntelliJ Platform Artifacts Repositories
# -> https://plugins.jetbrains.com/docs/intellij/intellij-artifacts.html
pluginGroup=com.sourcegraph.jetbrains
pluginName=Cody: AI Coding Assistant with Autocomplete & Chat
pluginName=AI Code Assistant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalanchan Is this intended? This is not just the description but the display name. This will probably be super confusing if it appears in JetBrains marketplace as “AI Code Assistant”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? I'm taking it off the copy from notion

should we mention Sourcegraph in the title to make it less confusing?

vscode/package.json Outdated
@@ -2,12 +2,12 @@
"$schema": "package.schema.json",
"name": "cody-ai",
"private": true,
"displayName": "Cody: AI Coding Assistant with Autocomplete & Chat",
"displayName": "AI Code Assistant",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, are we sure we want to update the displayName here?

@kalanchan
Copy link
Contributor Author

I’ve left some comments, I think @beyang should take a look too

yeah thats a good idea, let's tag him in slack for a review

@kalanchan kalanchan disabled auto-merge January 29, 2025 07:45
@umpox umpox requested a review from beyang January 29, 2025 09:03
@umpox
Copy link
Contributor

umpox commented Jan 29, 2025

@kalanchan Related: https://sourcegraph.slack.com/archives/CNC4YAL1E/p1738149320400439

I've updated the name, LMK if you have any final thoughts

umpox
umpox approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umpox
Copy link
Contributor

umpox commented Jan 29, 2025

@kalanchan Going to merge this and backport so this is all ready for the release. LMK if you want to change anything last minute!

@umpox umpox merged commit 958ff1a into main Jan 29, 2025
19 checks passed
@umpox umpox deleted the kalan/update-listing-description branch January 29, 2025 15:16
This was referenced Jan 29, 2025
Merged
Merged
umpox pushed a commit that referenced this pull request Jan 29, 2025
@sourcegraph-release-bot @kalanchan
[Backport vscode-v1.64.x] chore(marketing): update listing description (
19bdf48 
#6874)

Updating plugin description as requested by Marketing
([thread](https://sourcegraph.slack.com/archives/C0814PENH8R/p1738104682911269))

[Copy from
Notion](https://www.notion.so/sourcegraph/1-29-Update-for-3rd-Party-Listings-188a8e112658809faec0f6edeb94a521?showMoveTo=true&saveParent=true)

## Test plan
N/A - text change but we should test whether this uploads successfully
in the marketplace

 <br> Backport 958ff1a from #6862

Co-authored-by: Kalan <51868853+kalanchan@users.noreply.github.com>
umpox pushed a commit that referenced this pull request Jan 29, 2025
@sourcegraph-release-bot @kalanchan
[Backport jb-v7.12.x] chore(marketing): update listing description (#…
54ffdee 
…6875)

Updating plugin description as requested by Marketing
([thread](https://sourcegraph.slack.com/archives/C0814PENH8R/p1738104682911269))

[Copy from
Notion](https://www.notion.so/sourcegraph/1-29-Update-for-3rd-Party-Listings-188a8e112658809faec0f6edeb94a521?showMoveTo=true&amp;saveParent=true)

## Test plan
N/A - text change but we should test whether this uploads successfully
in the marketplace

 <br> Backport 958ff1a from #6862

Co-authored-by: Kalan <51868853+kalanchan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umpox umpox umpox approved these changes

@beyang beyang Awaiting requested review from beyang

Assignees
No one assigned
Labels
backport jb-v7.12.x backport vscode-v1.64.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalanchan @umpox