more lenient tree-sitter dep range #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/tree-sitter-dep-ver
branch
2 times, most recently
from
00ce2b9 to
820feae
Compare
This makes it possible to depend on `tree-sitter-jsonnet` from packages using newer versions of `tree-sitter`.
sqs
force-pushed
the
sqs/tree-sitter-dep-ver
branch
from
820feae to
9dea030
Compare
Comment on lines
-23
to
+18
| tree-sitter = "0.22.6" | ||
| tree-sitter = "^0.24.5" |
There was a problem hiding this comment.
This is not more lenient than the previous range (the PR title says "more lenient tree-sitter dep range"). The meaning of 0.22.6 is 0.22.6 <= v < 0.23. The meaning of ^0.24.5 is 0.24.5 <= v < 0.25. So the ranges do not have overlap.
What is the reason for bumping the ranges here? Is it for the syntax highlighter in the monorepo?
Over there, we need all grammars to be compiled with the same version of tree-sitter. Right now, the Cargo.toml for the workspace in the monorepo requires 0.22.6 <= v < 0.23.
| "tree-sitter": "^0.21.0" | ||
| "tree-sitter": "^0.22.4" |
There was a problem hiding this comment.
This seems odd/unusual... Why is the library dependency version different from the CLI version below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to depend on
tree-sitter-jsonnetfrom packages using newer versions oftree-sitter.