Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-839] Run GH Actions workflow on ubuntu-22.04 instead of ubuntu-latest #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

armintaenzertng
Copy link
Collaborator

@armintaenzertng armintaenzertng commented Jan 24, 2025

fixes #839

ubuntu-latest does not support Python 3.7 anymore.
See actions/runner-images#10636

…-latest

ubuntu-latest does not support Python 3.7 anymore.
See actions/runner-images#10636

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng armintaenzertng force-pushed the issue-839-fix-github-actions-workflow branch from 1afd311 to 55ce856 Compare January 24, 2025 09:07
@kestewart
Copy link
Contributor

Concerned that we should not be pegging to a version of Ubuntu which will become stale. What are the implications of updating to a newer version of python?

@kestewart kestewart requested a review from licquia January 24, 2025 15:42
@armintaenzertng
Copy link
Collaborator Author

@kestewart, it's not about upgrading our Python version (we already support at least 3.11) but about whether we want to drop Python 3.7 support.
Python 3.7 reached end-of-life on 2023-06-27, but still seems to be in use by some people.

Note that we wouldn't immediately lose compatibility when erasing it from the pipeline, but we wouldn't catch changes in our code that break for Python 3.7, so we couldn't guarantee 3.7 support anymore.

@maxhbr
Copy link
Member

maxhbr commented Jan 31, 2025

I think we should drop support for python versions that are EOL

@kestewart
Copy link
Contributor

@armintaenzertng, @maxhbr - no issue with dropping support - what I was objecting to was the pegging to an old version of ubuntu, rather than staying with the latest. If I've misunderstood what the patch is doing, please explain.

@maxhbr
Copy link
Member

maxhbr commented Jan 31, 2025

good point, lets drop old versions and stay with latest ubuntu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some checks, that are not allways running, are marked as mandatory
3 participants