fix(logging): disable logging in shim to improve performance

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
spinframework · Feb 23, 2024 · f88ffaa · f88ffaa
1 parent fe06e73
commit f88ffaa
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/containerd-shim-spin/Cargo.toml b/containerd-shim-spin/Cargo.toml
@@ -12,6 +12,7 @@ Containerd shim for running Spin workloads.
 
 [dependencies]
 containerd-shim-wasm = { git = "https://github.com/jsturtevant/runwasi", branch = "runwasi-precompile-take-2" }
+containerd-shim = "0.6.0"
 log = "0.4"
 spin-app = { git = "https://github.com/fermyon/spin", branch = "load-aot-compiled-components" }
 spin-core = { git = "https://github.com/fermyon/spin", branch = "load-aot-compiled-components" }

diff --git a/containerd-shim-spin/src/main.rs b/containerd-shim-spin/src/main.rs
@@ -1,8 +1,22 @@
+use containerd_shim::Config;
 use containerd_shim_wasm::container::Instance;
 use containerd_shim_wasm::sandbox::cli::{revision, shim_main, version};
 
 mod engine;
 
 fn main() {
-    shim_main::<Instance<engine::SpinEngine>>("spin", version!(), revision!(), "v2", None);
+    // Configure the shim to disable all logging for performance improvements.
+    // TODO: consider supporting some logging once log level specification is
+    // supported in https://github.com/containerd/rust-extensions/pull/247
+    let shim_config = Config {
+        no_setup_logger: true,
+        ..Default::default()
+    };
+    shim_main::<Instance<engine::SpinEngine>>(
+        "spin",
+        version!(),
+        revision!(),
+        "v2",
+        Some(shim_config),
+    );
 }