Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pluginsdk): Allow overriding proxy ports in deck dev-proxy #10115

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

dylanwatsonsoftware
Copy link
Contributor

This PR adds the following environment variables to the deck dev-proxy:

  • DEV_PROXY_HTTP_PORT
  • DEV_PROXY_HTTPS_PORT

By default dev-proxy (used for deck and deck plugin development) runs on port 9000 and 9443.
Sometimes these ports are inappropriate or already in use, so we need the ability to configure them.

This follows the pattern of the existing DEV_PROXY_HOST env var and exposes an additional 2 env vars.

They can also be configured by adding fields into the package.json of the running project via:

{

    ...rest of the package.json

    "devProxy": {
        "httpPort": 9000,
        "httpsPort": 9443
    }
}

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • f8ca3f1: Allow DEV_PROXY_HTTP_PORT and DEV_PROXY_HTTPS_PORT env vars to override proxy ports

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@mattgogerly
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 21, 2024

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Reviewed and ready for merge label Jun 21, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 26, 2024
@mergify mergify bot merged commit 3fe8402 into spinnaker:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.35
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants