Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws): Fix userData getting lost when cloning an AWS server group that uses launch templates (#6771) #10132

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(aws): Fix userData getting lost when cloning an AWS server group that uses launch templates (#6771) #10132

merged 1 commit into from
Sep 10, 2024

Conversation

ashleykleynhans
Copy link
Contributor

Fixes issue 6771.

deck-fix

@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Sep 10, 2024
@dbyron-sf
Copy link
Contributor

@ashleykleynhans can you run yarn prettier please?

@ashleykleynhans
Copy link
Contributor Author

@dbyron-sf apologies for that, its been done now.

@dbyron-sf
Copy link
Contributor

@ashleykleynhans No worries at all! Thank you for the fix!

@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 10, 2024
@mergify mergify bot merged commit d5a8ea3 into spinnaker:master Sep 10, 2024
4 checks passed
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.28.x release-1.29.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x release-1.34.x release-1.35.x

@dbyron-sf
Copy link
Contributor

Not sure many of these we'll actually release, but let's at least get the branches in shape.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024 •
edited
Loading

backport release-1.28.x release-1.29.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x release-1.34.x release-1.35.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
2e91835 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
4d8156c 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
6683248 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
9c00cf8 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
61cd269 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
18e37ad 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
This was referenced Sep 10, 2024
Merged
Open
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
7703d41 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@ashleykleynhans @mergify
fix(aws): Fix userData getting lost when cloning an AWS server group …
5cfdda6 
…that uses launch templates (#6771) (#10132)

(cherry picked from commit d5a8ea3)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
9b92dac 
…that uses launch templates (#6771) (#10132) (#10134)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
ba13219 
…that uses launch templates (#6771) (#10132) (#10140)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
a692106 
…that uses launch templates (#6771) (#10132) (#10141)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
59fa25a 
…that uses launch templates (#6771) (#10132) (#10135)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
8d74512 
…that uses launch templates (#6771) (#10132) (#10136)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
9c850c3 
…that uses launch templates (#6771) (#10132) (#10137)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 10, 2024
@mergify @ashleykleynhans
fix(aws): Fix userData getting lost when cloning an AWS server group …
fe16461 
…that uses launch templates (#6771) (#10132) (#10138)

(cherry picked from commit d5a8ea3)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
@igcherkaev igcherkaev mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.36
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleykleynhans @dbyron-sf @spinnakerbot