Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evaluateVariables stage) Made fetch exec history on evaluateVariables stage configurable #10143

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

wooseung-sim
Copy link
Contributor

Evaluate Variables stage on pipeline config view loads previous 100 pipeline execution history to show the evaluated variable values on previous execution.

The size of execution context is too huge if the pipeline is lengthy and it has a lot of artifacts and have a lot of previous executions. One of our pipeline is not accessible evaluate variables stage in the pipeline config as it timed out on executionService.getExecutionsForConfigIds() executions always due to size of the response (~400MB) and slowness of the VPN network.

phoenix-mcd_·_pipeline_config

Spinning circle UI is keep going and then timed out usually due to slowness of the network and size of the http get response.

This change can make the number of fetching history configurable on settings-local.js

window.spinnakerSettings.maxFetchHistoryOnEvaluateVariables = 5;

Default value of it is 100 if it is not defined on settings-local.js.

With this change we can adjust fetch history size for evaluate variable stage config UI, and prevent UI delays and errors.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 293fe55: Made fetch exec history on evaluateVariables stage configurable

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@wooseung-sim wooseung-sim force-pushed the feat/max_fetch_history_config branch from 293fe55 to 40c97e0 Compare September 11, 2024 18:50
@wooseung-sim wooseung-sim force-pushed the feat/max_fetch_history_config branch from 40c97e0 to 9aec3e0 Compare September 11, 2024 18:52
@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Sep 11, 2024
@dbyron-sf
Copy link
Contributor

@wooseung-sim can you run yarn prettier please?

@wooseung-sim
Copy link
Contributor Author

@wooseung-sim can you run yarn prettier please?

Thank you for letting me know. Ran it and pushed fixed commit.

@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 12, 2024
@mergify mergify bot merged commit 08b95df into spinnaker:master Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.36
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants